[ https://issues.apache.org/jira/browse/KAFKA-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654446#comment-14654446 ]
Jiangjie Qin commented on KAFKA-2402: ------------------------------------- Hi [~ashishujjain], I replied to your comments on the PR. Unit test is a little bit hard to do here because this issue comes from a rolling upgrade. KAFKA-1888 is supposed to address this and that might be a non-trivial work by itself. > Broker should create zkpath /isr_change_notification if it does not exist. > -------------------------------------------------------------------------- > > Key: KAFKA-2402 > URL: https://issues.apache.org/jira/browse/KAFKA-2402 > Project: Kafka > Issue Type: Bug > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > > This is a follow up patch for KAFKA-1367. > When broker update ISR of partitions, it should ensure zkPath > /isr_change_notification exist. This does not matter when users do a clean > deploy of Kafka cluster because controller will always create the cluster. > But it matters when users are doing a rolling upgrade since the controller > could still be running on a old version broker. In that case, > ZkNoNodeException will be thrown and replica fetching will fail. > We can either document the upgrade process to ask user create the zk path > manually before upgrade or preferably we can handle it in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)