On Thu, Jul 30, 2015 at 6:04 PM, Gwen Shapira <gshap...@cloudera.com> wrote:
> I wasn't aware of this history, thanks for explaining! > No problem. :) In most Apache projects I contributed to, the list of things that are > stated in "reviewed by" are implied in a committer committing the > patch. Reviewers are there to help the committer make the decision > (thats why I sometimes mention "@ewencp please take a look and let me > know what you think" in a JIRA), but the responsibility is on the > committer, not the reviewers. Reviewing by community members is > considered a valued contribution, and therefore "acknowledged" in the > commit message (or sometimes in the JIRA). > Understood. If the intent is to avoid surprises (which is a good idea), once we > decide on how we do things we can clarify in the contributor guide > (even if the decision is to keep current method, we should document > it) > Excellent, this is indeed the main thing for me. Best, Ismael
