[ https://issues.apache.org/jira/browse/KAFKA-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641246#comment-14641246 ]
Guozhang Wang commented on KAFKA-2349: -------------------------------------- [~ijuma] Looks good to me overall. One thing is that we tend to forget changing the documents / wiki pages when we make user-facing changes over time, and I blame myself for doing that multiple times. I would add a few lines in the patch for reminding contributor to think about possible doc / website / wiki changes when they submit their code change as well. Will do so if it sounds good to you. I think there are some discussions that we should move the website into the same repo as the code so that a single patch could include both, that may be a good direction to go in the future. > `contributing` website page should link to "Contributing Code Changes" wiki > page > -------------------------------------------------------------------------------- > > Key: KAFKA-2349 > URL: https://issues.apache.org/jira/browse/KAFKA-2349 > Project: Kafka > Issue Type: Task > Reporter: Ismael Juma > Assignee: Ismael Juma > Attachments: KAFKA-2349.patch > > > This should be merged at the same time as > https://issues.apache.org/jira/browse/KAFKA-2321 and only after a vote takes > place in the mailing list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)