[ 
https://issues.apache.org/jira/browse/KAFKA-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640181#comment-14640181
 ] 

ASF GitHub Bot commented on KAFKA-2358:
---------------------------------------

GitHub user sslavic opened a pull request:

    https://github.com/apache/kafka/pull/96

    KAFKA-2358 KafkaConsumer.partitionsFor returns empty list for non-existing 
topic

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sslavic/kafka feature/KAFKA-2358

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 31f70d27c88a9e76e7f812f069c6128121eeff1f
Author: Stevo Slavic <ssla...@gmail.com>
Date:   2015-07-24T09:03:04Z

    KAFKA-2358 KafkaConsumer.partitionsFor returns empty list for non-existing 
topic

----


> KafkaConsumer.partitionsFor should never return null
> ----------------------------------------------------
>
>                 Key: KAFKA-2358
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2358
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8.3
>            Reporter: Stevo Slavic
>            Priority: Minor
>
> {{KafkaConsumer.partitionsFor}} method by it's signature returns a 
> {{List<PartitionInfo>}}. Problem is that in case (metadata for) topic does 
> not exist, current implementation will return null, which is considered a bad 
> practice - instead of null it should return empty list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to