> On July 22, 2015, 10:40 a.m., Ismael Juma wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 401 > > <https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line401> > > > > Is it intentional to ignore `java.lang.Error` too? > > Jiangjie Qin wrote: > I think java.lang.Error is a subclass of throwables. > > Ismael Juma wrote: > Yes, it is and hence the question. To be clear: I am asking, do we want > to catch java.lang.Error exceptions like `OutOfMemoryError` and `ThreadDeath` > and swallow them instead of letting them propagate? Maybe this is what we > want, but I want to make sure that's understood.
It largely depends why out of memory occured. For example, a highly compressable message might coming and eat huge amount of memory after decompression. In this case, we might see OOM. In this case, the broker will just throw away the message, return an error to client and move on. Or maybe the huge message get through and got written to disk so the memory got release, in that case we also wants to move on. We see such kind of situation from time to time. There might be some other OOM but generally speaking, we just want to skip that and continue. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36664/#review92574 ----------------------------------------------------------- On July 23, 2015, 12:51 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36664/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 12:51 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2353 > https://issues.apache.org/jira/browse/KAFKA-2353 > > > Repository: kafka > > > Description > ------- > > Addressed Gwen's comments > > > Addressed Gwen's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36664/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
