Hi, We've been using the new Kafka Metrics within Voldemort for a little while now, and we have made some improvements to the library that you might like to copy back into Kafka proper. You can view the changes that went in after we forked here:
https://github.com/tehuti-io/tehuti/commits/master The most critical ones are probably these two: - A pretty simpe yet nasty bug in Percentile that pretty much made Histograms useless otherwise: https://github.com/tehuti-io/tehuti/commit/913dcc0dcc79e2ce87a4c3e52a1affe2aaae9948 - A few improvements to SampledStat (unfortunately littered across several commits) were made to prevent spurious values from being measured out of a disproportionately small time window (either initally, or because all windows expired in the case of an infrequently used stat) : https://github.com/tehuti-io/tehuti/blob/master/src/main/java/io/tehuti/metrics/stats/SampledStat.java There were other minor changes here and there, to make the APIs more usable (IMHO) though that may be a matter of personal taste more than correctness. If you're interested in the above changes, I could put together a patch and file a JIRA. Or someone else can do it if they prefer. On an unrelated note, if you do merge the changes back into Kafka, it would be nice if you considered releasing kafka-metrics as a standalone artifact. Voldemort could depend on kafka-metrics rather than tehuti if it was fixed properly, but it would be a stretch for Voldemort to depend on all of Kafka (or even Kafka clients...). The fork was just to iterate quicker at the time we needed this, but it would be nice to bring it back together. Let me know if I can help in any way. -- *Felix GV* Senior Software Engineer Data Infrastructure LinkedIn f...@linkedin.com linkedin.com/in/felixgv
