----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92105 -----------------------------------------------------------
core/src/main/scala/kafka/common/TopicAlreadyMarkedForDeletionException.scala (line 21) <https://reviews.apache.org/r/36565/#comment146045> Won't hurt, but as you mentioned putting message is a good practice. Will update. - Ashish Singh On July 17, 2015, 5:21 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36565/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 5:21 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2345 > https://issues.apache.org/jira/browse/KAFKA-2345 > > > Repository: kafka > > > Description > ------- > > KAFKA-2345: Attempt to delete a topic already marked for deletion throws > ZkNodeExistsException > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala > f06edf41c732a7b794e496d0048b0ce6f897e72b > > core/src/main/scala/kafka/common/TopicAlreadyMarkedForDeletionException.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/36565/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
