[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631564#comment-14631564 ]
Ismael Juma commented on KAFKA-2344: ------------------------------------ I renamed the JIRA title, I hope you don't mind. If improvements are needed on how the JIRA credentials are configured, a separate issue should be filed. I think it would be nice if it it also supported the same mechanism as the `kafka-patch-review.py` tool for consistency (if we want to keep both tools, that is). It would be a nice way for someone else to improve the script too. ;) > kafka-merge-pr should support reviewers in commit message > --------------------------------------------------------- > > Key: KAFKA-2344 > URL: https://issues.apache.org/jira/browse/KAFKA-2344 > Project: Kafka > Issue Type: Improvement > Reporter: Gwen Shapira > Assignee: Ismael Juma > Priority: Minor > > Two suggestions for the new pr-merge tool: > * The tool doesn't allow to credit reviewers while committing. I thought the > review credits were a nice habit of the Kafka community and I hate losing it. > OTOH, I don't want to force-push to trunk just to add credits. Perhaps the > tool can ask about committers? > * Looks like the tool doesn't automatically resolve the JIRA. Would be nice > if it did. -- This message was sent by Atlassian JIRA (v6.3.4#6332)