-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36333/
-----------------------------------------------------------
(Updated July 14, 2015, 1:45 a.m.)
Review request for kafka.
Bugs: KAFKA-2123
https://issues.apache.org/jira/browse/KAFKA-2123
Repository: kafka
Description (updated)
-------
KAFKA-2123; resolve problems from rebase
KAFKA-2123; address review comments
KAFKA-2123; more review fixes
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
fd98740bff175cc9d5bc02e365d88e011ef65d22
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerCommitCallback.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceCallback.java
74dfdba0ecbca04947adba5eabb1cb5190a0cd5f
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java
eb75d2e797e3aa3992e4cf74b12f51c8f1545e02
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
b4e8f7f0dceefaf94a3495f39f5783cce5ceb25f
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
46e26a665a22625d50888efa7b53472279f36e79
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
c1c8172cd45f6715262f9a6f497a7b1797a834a3
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DelayedTask.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DelayedTaskQueue.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
695eaf63db9a5fa20dc2ca68957901462a96cd96
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Heartbeat.java
51eae1944d5c17cf838be57adf560bafe36fbfbd
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NoAvailableBrokersException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestFuture.java
13fc9af7392b4ade958daf3b0c9a165ddda351a6
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestFutureAdapter.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestFutureListener.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SendFailedException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StaleMetadataException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
683745304c671952ff566f23b5dd4cf3ab75377a
clients/src/main/java/org/apache/kafka/common/errors/ConsumerCoordinatorNotAvailableException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/DisconnectException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/IllegalGenerationException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/NotCoordinatorForConsumerException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/OffsetLoadInProgressException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/UnknownConsumerIdException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
4c0ecc3badd99727b5bd9d430364e61c184e0923
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClientTest.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java
d085fe5c9e2a0567893508a1c71f014fae6d7510
clients/src/test/java/org/apache/kafka/clients/consumer/internals/DelayedTaskQueueTest.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
405efdc7a59438731cbc3630876bda0042a3adb3
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatTest.java
ee1ede01efa070409b86f5d8874cd578e058ce51
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestFutureTest.java
PRE-CREATION
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
92ffb91b5e039dc0d4cd0e072ca46db32f280cf9
Diff: https://reviews.apache.org/r/36333/diff/
Testing
-------
Thanks,
Jason Gustafson
