Joe, I think the issue that Ismael want to raise discussion for is that today, we are "unofficially" sticking with JIRA tickets for all of our commits (i.e. it is not enforced in bylaws but we are doing it anyways), for example, following today's RB-based review process people are creating JIRAs for typo fixes as well:
https://issues.apache.org/jira/browse/KAFKA-1957?jql=project%20%3D%20KAFKA%20AND%20text%20~%20%22typo%22 Now we are trying to migrate from RB to PR, in the proposed wiki ( https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes) it is suggested people creating their PR with [KAFKA-XXX] as title prefix, so effectively suggesting we will enforce it, while on the same page we are also following Spark's statement that "if it is minor you do not need to create a JIRA", so I was discussing with Ismael that we should clear this confusion and clarify which approach we should really pursue, whether changing the statement in wiki that "you could create a PR with [KAFKA-XXXX] or [MINOR], [HOTFIX], etc" or sticking that "you should always create a JIRA and make the PR title accordingly". Guozhang On Mon, Jul 13, 2015 at 6:54 AM, Ismael Juma <ism...@juma.me.uk> wrote: > On Mon, Jul 13, 2015 at 2:41 PM, Joe Stein <joe.st...@stealth.ly> wrote: > > > If the patch lives on a pull request and is a simple hotfix a committer > > could +1 and commit it. I don't see anything in the > > https://cwiki.apache.org/confluence/display/KAFKA/Bylaws preventing this > > already now. > > > Good. > > > > I guess I am still struggling between what is not setup that > > you think we need to get setup or changes that you are looking to make > > differently? What are we trying to discuss and decide up in regards to > > this? > > > > Nothing needs to be set-up. It's just a matter of agreeing the process so > that the new (in-progress) page for contributing code changes can be > accurate ( > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > ). > If you look at http://kafka.apache.org/contributing.html, it says that a > JIRA needs to be created, for example. Also, in the original pull request > thread, Guozhang said the same. If you think differently, it's even more > reason to clarify our position. :) > > Best, > Ismael > -- -- Guozhang
