Correction to my previous email — it's slf4j-log4j12-1.7.6.jar and slf4j-log4j12-1.6.1.jar that were being copied into dependant-libs, not slf4j-api variants.
On Tue, Jul 7, 2015 at 8:27 AM, Stevo Slavić <ssla...@gmail.com> wrote: > Hello Jun, > > I can easily reproduce the issue with previous commit (RAT). > While on latest trunk branch: > > $ git checkout HEAD^ > $ gradle clean > $ gradle copyDependantLibs > $ ls -lart core/build/dependant-libs-2.10.5/ > > lists slf4j-api-1.7.6.jar and slf4j-api-1.6.1.jar > > Not sure exactly which modification in last commit did it, but issue is no > longer there as of last commit. > > Thanks! > > Kind regards, > Stevo Slavic. > > On Tue, Jul 7, 2015 at 7:10 AM, Jun Rao <j...@confluent.io> wrote: > >> Stevo, >> >> I don't see duplicated slf4j-log4j12 jars under core/build/dependant-libs >> after a clean build in trunk. If this is still an issue, could you file a >> jira and describe how to reproduce this? >> >> Thanks, >> >> Jun >> >> On Fri, Jun 26, 2015 at 2:19 PM, Stevo Slavić <ssla...@gmail.com> wrote: >> >> > Are changes for KAFKA-2132 ticket supposed also to fix bug that core >> > dependent libraries (core/build/dependant-libs) for all different >> supported >> > Scala version, contain two versions of slf4j-log4j12 >> > (slf4j-log4j12-1.6.1.jar leaking from zookeeper 3.4.6 dependency, and >> test >> > scoped slf4j-log4j12-1.7.6.jar dependency - latter is explicitly added >> for >> > some reason in copyDependantLibs task, but it does not override >> > slf4j-log4j12 leak from zookeeper) ? >> > >> > It's the source of annoying: >> > >> > SLF4J: Class path contains multiple SLF4J bindings. >> > SLF4J: Found binding in >> > >> > >> [jar:file:/Users/foo/kafka/core/build/dependant-libs-2.10.5/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class] >> > SLF4J: Found binding in >> > >> > >> [jar:file:/Users/foo/kafka/core/build/dependant-libs-2.10.5/slf4j-log4j12-1.7.6.jar!/org/slf4j/impl/StaticLoggerBinder.class] >> > SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an >> > explanation. >> > SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] >> > >> > whenever a script like bin/kafka-topics.sh is run. >> > >> > Or should separate ticket be filed for this issue? >> > >> > Kind regard, >> > Stevo Slavic. >> > >> > On Wed, Jun 24, 2015 at 7:26 PM, Ashish K Singh (JIRA) <j...@apache.org >> > >> > wrote: >> > >> > > >> > > [ >> > > >> > >> https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599778#comment-14599778 >> > > ] >> > > >> > > Ashish K Singh commented on KAFKA-2132: >> > > --------------------------------------- >> > > >> > > Updated reviewboard https://reviews.apache.org/r/33614/ >> > > against branch trunk >> > > >> > > > Move Log4J appender to a separate module >> > > > ---------------------------------------- >> > > > >> > > > Key: KAFKA-2132 >> > > > URL: >> https://issues.apache.org/jira/browse/KAFKA-2132 >> > > > Project: Kafka >> > > > Issue Type: Improvement >> > > > Reporter: Gwen Shapira >> > > > Assignee: Ashish K Singh >> > > > Attachments: KAFKA-2132.patch, >> > > KAFKA-2132_2015-04-27_19:59:46.patch, >> > KAFKA-2132_2015-04-30_12:22:02.patch, >> > > KAFKA-2132_2015-04-30_15:53:17.patch, >> > KAFKA-2132_2015-06-13_21:18:59.patch, >> > > KAFKA-2132_2015-06-24_10:19:56.patch, >> > KAFKA-2132_2015-06-24_10:25:43.patch >> > > > >> > > > >> > > > Log4j appender is just a producer. >> > > > Since we have a new producer in the clients module, no need to keep >> > > Log4J appender in "core" and force people to package all of Kafka with >> > > their apps. >> > > > Lets move the Log4jAppender to clients module. >> > > >> > > >> > > >> > > -- >> > > This message was sent by Atlassian JIRA >> > > (v6.3.4#6332) >> > > >> > >> > >
