> On June 22, 2015, 4:23 a.m., Jun Rao wrote: > > Thanks for the patch. I created a topic w/o customized config. On broker > > startup, I still saw the following logging. > > > > [2015-06-21 21:01:21,569] INFO Read configuration for topic test > > (kafka.server.KafkaServer) > > [2015-06-21 21:01:21,569] INFO LogConfig values: > > segment.bytes = 1073741824 > > (kafka.log.LogConfig) > > > > In general, I am wondering if it will be too verbose to log even overriden > > configs when a broker has thousands of topics. Also, the user can always > > find out the overriden configs through the admin tool. The reason that we > > log the broker config is that there is no such tool.
You are right, it will be too much on large clusters. I'll remove the extra logging. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35677/#review88723 ----------------------------------------------------------- On June 20, 2015, 12:59 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35677/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 12:59 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2288 > https://issues.apache.org/jira/browse/KAFKA-2288 > > > Repository: kafka > > > Description > ------- > > minor corrections to LogConfig and KafkaConfigTest > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > bae528d31516679bed88ee61b408f209f185a8cc > core/src/main/scala/kafka/log/LogConfig.scala > fc41132d2bf29439225ec581829eb479f98cc416 > core/src/main/scala/kafka/server/KafkaServer.scala > 52dc728bb1ab4b05e94dc528da1006040e2f28c9 > core/src/test/scala/unit/kafka/log/LogConfigTest.scala > 19dcb47f3f406b8d6c3668297450ab6b534e4471 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > 98a5b042a710d3c1064b0379db1d152efc9eabee > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2428dbd7197a58cf4cad42ef82b385dab3a2b15e > > Diff: https://reviews.apache.org/r/35677/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
