[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594429#comment-14594429
]
Onur Karaman commented on KAFKA-2245:
-------------------------------------
The original patch resulted in ReplicaManagerTest failures specifically with
./gradlew cleanTest test because ConsumerCoordinatorResponseTest wasn't
shutting down the ConsumerCoordinator. It actually left some threads running,
and ReplicaManagerTest was checking for the existence of some threads.
The updated patch should address this:
https://reviews.apache.org/r/35086/diff/2/
> Add response tests for ConsumerCoordinator
> ------------------------------------------
>
> Key: KAFKA-2245
> URL: https://issues.apache.org/jira/browse/KAFKA-2245
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Onur Karaman
> Assignee: Onur Karaman
> Priority: Critical
> Fix For: 0.8.3
>
> Attachments: KAFKA-2245.patch, KAFKA-2245_2015-06-19_22:55:56.patch
>
>
> We can validate error codes from JoinGroupResponses and HeartbeatResponses.
> Currently this includes:
> - JoinGroupRequest to the wrong coordinator returns
> NOT_COORDINATOR_FOR_CONSUMER
> - JoinGroupRequest with an unknown partition assignment strategy returns
> UNKNOWN_PARTITION_ASSIGNMENT_STRATEGY
> - JoinGroupRequest with an out-of-range session timeout returns
> INVALID_SESSION_TIMEOUT
> - JoinGroupRequest on a brand new group with an unrecognized consumer id
> produces UNKNOWN_CONSUMER_ID
> - JoinGroupRequest with mismatched partition assignment strategy compared to
> the rest of the group returns INCONSISTENT_PARTITION_ASSIGNMENT_STRATEGY
> - JoinGroupRequest on an existing group with an unrecognized consumer id
> produces UNKNOWN_CONSUMER_ID
> - A correct JoinGroupRequest returns NONE
> - HeartbeatRequest to the wrong coordinator returns
> NOT_COORDINATOR_FOR_CONSUMER
> - HeartbeatRequest with an unknown group returns UNKNOWN_CONSUMER_ID
> - HeartbeatRequest with an unrecognized consumer id returns
> UNKNOWN_CONSUMER_ID
> - HeartbeatRequest with generation id mismatch returns ILLEGAL_GENERATION
> - A correct HeartbeatRequest returns NONE
> We can validate the generation id increments on rebalance based on the
> JoinGroupResponse.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
