I think this is just a mistake and you should definitely fix it. Nice catch.
-Jay On Wed, Jun 17, 2015 at 4:34 PM, Gwen Shapira <gshap...@cloudera.com> wrote: > Hi, > > I'm migrating KafkaConfig and LogConfig over to AbstractConfig > interface,and I've ran into something strange: > > All of LogConfig parameters also exist at KafkaConfig level. > However the defaults are completely different. Few examples: > > Maximum message size is 1000000 + MessageSet.LogOverhead in > KafkaConfig defaults, but MaxInt at LogConfig level. > > Segment size (bytes) is 1024 * 1024 * 1024 at KafkaConfig, but 1024 * > 1024 in LogConfig. > > This is true for most configs. > > From what I can see, LogConfigs are NEVER users, because LogManager is > initialized with values from KafkaConfig as the default LogConfig when > it starts. > > Anyone knows why LogConfig has different defaults? > Any objections to unifying them? > > Gwen >
