[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588170#comment-14588170
]
Jun Rao commented on KAFKA-1646:
--------------------------------
[~waldenchen], thanks for the latest patch. A couple of other issues.
1. There are two unit test failures.
unit.kafka.log.LogConfigTest > testFromPropsToProps FAILED
org.apache.kafka.common.config.ConfigException: Invalid value 1352153985
for configuration preallocate: Expected value to be either true or false
at
org.apache.kafka.common.config.ConfigDef.parseType(ConfigDef.java:210)
at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:172)
at kafka.log.LogConfig$.fromProps(LogConfig.scala:208)
at
unit.kafka.log.LogConfigTest.testFromPropsToProps(LogConfigTest.scala:66)
unit.kafka.server.KafkaConfigConfigDefTest > testFromPropsToProps FAILED
org.apache.kafka.common.config.ConfigException: Invalid value 619129959 for
configuration log.preallocate: Expected value to be either true or false
at
org.apache.kafka.common.config.ConfigDef.parseType(ConfigDef.java:210)
at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:172)
at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:531)
at
unit.kafka.server.KafkaConfigConfigDefTest.testFromPropsToProps(KafkaConfigConfigDefTest.scala:256)
2. We also create new FileMessageSet in LogCleaner.cleanSegments(). Should we
enable preallocation there as well?
> Improve consumer read performance for Windows
> ---------------------------------------------
>
> Key: KAFKA-1646
> URL: https://issues.apache.org/jira/browse/KAFKA-1646
> Project: Kafka
> Issue Type: Improvement
> Components: log
> Affects Versions: 0.8.1.1
> Environment: Windows
> Reporter: xueqiang wang
> Assignee: xueqiang wang
> Labels: newbie, patch
> Attachments: Improve consumer read performance for Windows.patch,
> KAFKA-1646-truncate-off-trailing-zeros-on-broker-restart-if-bro.patch,
> KAFKA-1646_20141216_163008.patch, KAFKA-1646_20150306_005526.patch,
> KAFKA-1646_20150511_AddTestcases.patch,
> KAFKA-1646_20150609_MergeToLatestTrunk.patch,
> KAFKA-1646_20150616_FixFormat.patch
>
>
> This patch is for Window platform only. In Windows platform, if there are
> more than one replicas writing to disk, the segment log files will not be
> consistent in disk and then consumer reading performance will be dropped down
> greatly. This fix allocates more disk spaces when rolling a new segment, and
> then it will improve the consumer reading performance in NTFS file system.
> This patch doesn't affect file allocation of other filesystems, for it only
> adds statements like 'if(Os.iswindow)' or adds methods used on Windows.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
