----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review86987 -----------------------------------------------------------
core/src/main/scala/kafka/server/DelayedOperation.scala <https://reviews.apache.org/r/35201/#comment139198> Will watchForOperation sound more precise? core/src/main/scala/kafka/server/DelayedOperation.scala <https://reviews.apache.org/r/35201/#comment139197> Here we are grabbing removeWatchersLock first then synchronize on the watchers. In tryCompleteWatched, we synchronize on the watcher first then grab the removeWatchersLock. Will there be a deadlock? - Jiangjie Qin On June 8, 2015, 4:46 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35201/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 4:46 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2253 > https://issues.apache.org/jira/browse/KAFKA-2253 > > > Repository: kafka > > > Description > ------- > > Incorporated Jiangjie and Onur's comments > > > Diffs > ----- > > core/src/main/scala/kafka/server/DelayedOperation.scala > 123078d97a7bfe2121655c00f3b2c6af21c53015 > > Diff: https://reviews.apache.org/r/35201/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
