----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/#review86754 -----------------------------------------------------------
Ship it! Thanks for this patch. I have a question below on why it fails on TestOffsetManager even after adding the license. Can you try it locally? In any event, I would like to delete that file altogether, but may be worth debugging why rat reported an issue. core/src/test/scala/other/kafka/TestOffsetManager.scala <https://reviews.apache.org/r/35076/#comment138824> This was an ad hoc test that I had written a while ago. I think we should remove it. Let me know if there are any objections. Also, the weird thing is even after you added the license header, I still get an error with `gradlew rat`: ``` ./gradlew clean && ./gradlew rat To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: http://gradle.org/docs/2.0/userguide/gradle_daemon.html. Building project 'core' with Scala version 2.10.5 :clean :clients:clean :contrib:clean :core:clean :examples:clean :contrib:hadoop-consumer:clean :contrib:hadoop-producer:clean BUILD SUCCESSFUL Total time: 7.9 secs To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: http://gradle.org/docs/2.0/userguide/gradle_daemon.html. Building project 'core' with Scala version 2.10.5 :rat Unknown license: /Users/jkoshy/Projects/kafka/out/test/core/other/kafka/TestOffsetManager.scala :rat FAILED FAILURE: Build failed with an exception. * Where: Script '/Users/jkoshy/Projects/kafka/gradle/rat.gradle' line: 63 * What went wrong: Execution failed for task ':rat'. > Found 1 files with unknown licenses. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 12.669 secs ``` - Joel Koshy On June 4, 2015, 4:35 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35076/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 4:35 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2248 > https://issues.apache.org/jira/browse/KAFKA-2248 > > > Repository: kafka > > > Description > ------- > > KAFKA-2248: Add Rat step to tests to ensure licenses are valid > > > Diffs > ----- > > .rat-excludes 01d629817c8a4b2db3c11d8e6a7fa13a7e4856c2 > build.gradle 30d1cf2f1ff9ed3f86a060da8099bb0774b4cf91 > core/src/test/scala/other/kafka/TestOffsetManager.scala > 8047da4ff5b995611bdae53f4f04d0791f1a34b4 > gradle/buildscript.gradle 5e45c06e8bb8b7c4cb681684023686a7b2252fb7 > gradle/license.gradle b4b62ebe277719b28bd131dde9e2a1cdb030e2a9 > gradle/rat.gradle PRE-CREATION > gradle/resources/rat-output-to-html.xsl PRE-CREATION > kafka-patch-review.py b5a2e950110d44d20d21e3d72be1783ceb49627d > scala.gradle cabb59c2a6289bc3a2673ddfa3842addf9a5bb44 > topics.json ff011ed381e781b9a177036001d44dca3eac586f > > Diff: https://reviews.apache.org/r/35076/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
