[
https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573097#comment-14573097
]
Ewen Cheslack-Postava commented on KAFKA-2248:
----------------------------------------------
Patch is mostly lifted from the Samza version. A couple of notes:
1. I attached the check to test rather than check so it runs under normal
developer steps before submitting a patch. One drawback to that is that it
doesn't look like you can control the order of gradle build steps yet and it
seems to run before the tests themselves, which is slightly inconvenient during
development.
2. I ignored everything under system_test/ because there's a KIP to replace
them and there was a lot of cleanup to be done there.
3. Extra files that match file types checked by Rat can cause failures. For
example, I had a couple of patch files in the root of my repo and had to clear
them out. Samza has the same issue, but they only run this during the check
step, so maybe most people don't notice it?
> Use Apache Rat to enforce copyright headers
> -------------------------------------------
>
> Key: KAFKA-2248
> URL: https://issues.apache.org/jira/browse/KAFKA-2248
> Project: Kafka
> Issue Type: Bug
> Components: build
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.8.3
>
> Attachments: KAFKA-2248.patch
>
>
> Follow up to KAFKA-2161. Use Apache Rat during builds to make sure copyright
> headers are present so we don't forget any and don't allow any incorrect ones
> to be checked in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
