[
https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567322#comment-14567322
]
nicu marasoiu edited comment on KAFKA-1282 at 6/1/15 2:24 PM:
--------------------------------------------------------------
Hi [~junrao], [~nehanarkhede], I added a test, please review. The patch has 2
variations (latest 2 patches), explained at point 2 below, while the latest
implements 1' below.
1. I wanted to sleep on MockTime, but here we actually need to physically wait
at leat one epoll/select cycle. Since I have put 10ms idle time & it works,
mocked time would not bring benefits, i.e. only the select time needs to be
waited over.
1'. Because of potentially large & not deterministically bounded select times,
I implemented a mechanism to try a few times, waiting 50% more time every time.
2. Seems to work with low (10ms) idle timeout for all current test methods.
However, I attach a patch with separate test class for this (and yet another
utils class for reuse), to isolate configuration between group of test methods.
3. Shall I do a multiple connections test?
was (Author: nmarasoi):
Hi [~junrao], [~nehanarkhede], I added a test, please review. The patch has 2
variations (latest 2 patches), explained at point 2 below.
1. I wanted to sleep on MockTime, but here we actually need to physically wait
at leat one epoll/select cycle. Since I have put 10ms idle time & it works,
mocked time would not bring benefits, i.e. only the select time needs to be
waited over.
1'. Because of potentially large & not deterministically bounded select times,
I will implement a mechanism to try a few times, waiting 50% more time every
time.
2. Seems to work with low (10ms) idle timeout for all current test methods.
However, I attach a patch with separate test class for this (and yet another
utils class for reuse), to isolate configuration between group of test methods.
3. Shall I do a multiple connections test?
> Disconnect idle socket connection in Selector
> ---------------------------------------------
>
> Key: KAFKA-1282
> URL: https://issues.apache.org/jira/browse/KAFKA-1282
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.8.2.0
> Reporter: Jun Rao
> Assignee: nicu marasoiu
> Labels: newbie++
> Fix For: 0.8.3
>
> Attachments: 1282_access-order_+_test_(same_class).patch,
> KAFKA-1282_Disconnect_idle_socket_connection_in_Selector.patch,
> access-order_+_test.patch,
> access_order_+_test_waiting_from_350ms_to_1100ms.patch
>
>
> To reduce # socket connections, it would be useful for the new producer to
> close socket connections that are idle. We can introduce a new producer
> config for the idle time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
