see below On Fri, May 29, 2015 at 2:25 AM, Jaikiran Pai <jai.forums2...@gmail.com> wrote:
> Could someone please look at these few review requests and let me know if > any changes are needed: > > https://reviews.apache.org/r/34394/ related to > https://issues.apache.org/jira/browse/KAFKA-1907 I haven't looked at all the other changes that would be introduced from their release that could break between zk and kafka by introducing a zk client bump. A less ops negative way to deal with this might be to create a plugable interface, then someone can use a patched zkclient if they wanted, or exhibitor, or consul, or akka, etc. > > https://reviews.apache.org/r/30403/ related to > https://issues.apache.org/jira/browse/KAFKA-1906 I don't understand the patch and how it would fix the issue. I also don't think necessarily there is an issue. Its a balance from the community having a good out of the box experience vs taking defaults and rushing them into production. No matter what we do we can't stop the latter from happening, which will also cause issues. > > > There's also this one https://reviews.apache.org/r/34697/ for > https://issues.apache.org/jira/browse/KAFKA-2221 but it's only been up > since a couple of days and is a fairly minor one. Folks should start to transition in 0.8.3 to the new java consumer (which is on trunk). If this fix is so critical we should release it in 0.8.2.2 otherwise continue to try to not make changes to the existing scalal consumer. > > > -Jaikiran >
