----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/#review85101 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/34608/#comment136577> Nit - avoid * imports. clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/34608/#comment136578> This isn't really related specifically to this patch, but I noticed the javadoc for this class is no longer accurate. Mind updating to make the example work again? clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/34608/#comment136580> One drawback to this is that we're now constantly reallocating these instead of just reusing the same ArrayLists repeatedly. I doubt this has a substantial impact, but given that this is core code, it' might be worth running some simple benchmark (e.g. ProducerPerformance) just to sanity check that we don't see a perf drop over a long run where GC issues might become an issue. clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/34608/#comment136579> checkstyle is complaining because this isn't indented correctly. - Ewen Cheslack-Postava On May 22, 2015, 7 p.m., Jason Gustafson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34608/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 7 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2217 > https://issues.apache.org/jira/browse/KAFKA-2217 > > > Repository: kafka > > > Description > ------- > > KAFKA-2217; Refactor Client Selectable Interface for Better Concurrency > Options > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > 435fbb5116e80302eba11ed1d3069cb577dbdcbd > clients/src/main/java/org/apache/kafka/common/network/PollResult.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/network/Selectable.java > b5f8d83e89f9026dc0853e5f92c00b2d7f043e22 > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 57de0585e5e9a53eb9dcd99cac1ab3eb2086a302 > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > d5b306b026e788b4e5479f3419805aa49ae889f3 > clients/src/test/java/org/apache/kafka/test/MockSelector.java > ea89b06a4c9e5bb351201299cd3037f5226f0e6c > > Diff: https://reviews.apache.org/r/34608/diff/ > > > Testing > ------- > > > Thanks, > > Jason Gustafson > >
