[ 
https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557821#comment-14557821
 ] 

Guozhang Wang commented on KAFKA-1737:
--------------------------------------

+1 except a couple of minor bugs that caused compilation to fail:

{code}
/home/guwang/Workspace/temp/kafka_review/core/src/test/scala/other/kafka/TestOffsetManager.scala:241:
 not found: value ZkUtils
      zkClient = ZkUtils.createZkClient(zookeeper, 6000, 2000)
                 ^
/home/guwang/Workspace/temp/kafka_review/core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala:37:
 not found: value ZkUtils
    zkClient = ZkUtils.createZkClient(zkConnect, zkSessionTimeout, 
zkConnectionTimeout)
               ^
two errors found
{code}

Added the imports and committed to trunk.

> Document required ZkSerializer for ZkClient used with AdminUtils
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1737
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1737
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 0.8.1.1
>            Reporter: Stevo Slavic
>            Assignee: Vivek Madani
>            Priority: Minor
>         Attachments: KAFKA-1737.patch, KAFKA-1737.patch
>
>
> {{ZkClient}} instances passed to {{AdminUtils}} calls must have 
> {{kafka.utils.ZKStringSerializer}} set as {{ZkSerializer}}. Otherwise 
> commands executed via {{AdminUtils}} may not be seen/recognizable to broker, 
> producer or consumer. E.g. producer (with auto topic creation turned off) 
> will not be able to send messages to a topic created via {{AdminUtils}}, it 
> will throw {{UnknownTopicOrPartitionException}}.
> Please consider at least documenting this requirement in {{AdminUtils}} 
> scaladoc.
> For more info see [related discussion on Kafka user mailing 
> list|http://mail-archives.apache.org/mod_mbox/kafka-users/201410.mbox/%3CCAAUywg-oihNiXuQRYeS%3D8Z3ymsmEHo6ghLs%3Dru4nbm%2BdHVz6TA%40mail.gmail.com%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to