----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34241/#review84276 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/34241/#comment135484> Do you think we should add that this really only works when in-flight requests is one? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/34241/#comment135480> `info("Flushing producer.")` - Joel Koshy On May 16, 2015, 2:50 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34241/ > ----------------------------------------------------------- > > (Updated May 16, 2015, 2:50 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2190 > https://issues.apache.org/jira/browse/KAFKA-2190 > > > Repository: kafka > > > Description > ------- > > Should flush before commit offsets when mirror maker thread exits on > exception. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 954852170d67cbb8ff4f113301816d2a2daf5e91 > > Diff: https://reviews.apache.org/r/34241/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
