----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31627/#review82926 -----------------------------------------------------------
Ship it! clients/src/main/java/org/apache/kafka/clients/NetworkClient.java <https://reviews.apache.org/r/31627/#comment133774> It could happen that even if cluster.nodes().size() > 0 while some transient error may happen as expected while refreshing metadata, such as UNKNOWN_TOPIC, so better moving out of if-else statement. - Guozhang Wang On March 2, 2015, 3:57 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31627/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 3:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1884 > https://issues.apache.org/jira/browse/KAFKA-1884 > > > Repository: kafka > > > Description > ------- > > Added logs to print metadata response errors > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > a7fa4a9dfbcfbc4d9e9259630253cbcded158064 > > Diff: https://reviews.apache.org/r/31627/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
