Hi Ewen, Comments inline.
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava <e...@confluent.io> wrote: > Also +1. There are some drawbacks to using Github for reviews, e.g. lots of > emails for each review because they don't let you publish your entire > review in one go like RB does, but it drastically lowers the barrier to > contributing for most developers. Also, if you haven't tried it, hub > https://hub.github.com/ makes it really easy to checkout and test PRs. > Good points. One thing I noticed is that when you try to generate a PR it defaults to > the 0.8.2 branch. Can we fix that up to be trunk by default? That's the > most common use case; version branches are really only useful when a > release is being prepared. Do changes to the Github repo require tickets to > the Apache Infra team or is this something committers have control over? > It can be changed to trunk, but it does require a ticket to the Infra team[1]. Sadly, PRs can only be closed via commits, PR creator or a ticket to Infra. This is quite clunky for abandoned PRs (a label can be used to exclude such PRs from view, if needed). On a related note, which perhaps should be discussed on another thread: > > The CI setup is a related issue that we might want to rethink. I did think about Travis as well, but I thought that should be considered as a subsequent and separate discussion indeed. Best, Ismael [1] An example of such a request: https://issues.apache.org/jira/browse/INFRA-9208
