----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33634/#review81869 -----------------------------------------------------------
Ship it! Your analysis sounds right, looks like the missing synchronized was just an oversight. - Ewen Cheslack-Postava On April 28, 2015, 6:12 p.m., Tim Brooks wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33634/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 6:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2129 > https://issues.apache.org/jira/browse/KAFKA-2129 > > > Repository: kafka > > > Description > ------- > > Synchronize method > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > d301be4709f7b112e1f3a39f3c04cfa65f00fa60 > > Diff: https://reviews.apache.org/r/33634/diff/ > > > Testing > ------- > > > Thanks, > > Tim Brooks > >
