[
https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513154#comment-14513154
]
Neha Narkhede commented on KAFKA-1886:
--------------------------------------
[~aauradkar] Took a quick look at your patch again. Are you planning on fixing
it so we can merge? Realize that the simple consumer changes are going to
matter less as we make more progress on the new consumer.
> SimpleConsumer swallowing ClosedByInterruptException
> ----------------------------------------------------
>
> Key: KAFKA-1886
> URL: https://issues.apache.org/jira/browse/KAFKA-1886
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Reporter: Aditya A Auradkar
> Assignee: Aditya Auradkar
> Attachments: KAFKA-1886.patch, KAFKA-1886.patch,
> KAFKA-1886_2015-02-02_13:57:23.patch
>
>
> This issue was originally reported by a Samza developer. I've included an
> exchange of mine with Chris Riccomini. I'm trying to reproduce the problem on
> my dev setup.
> From: criccomi
> Hey all,
> Samza's BrokerProxy [1] threads appear to be wedging randomly when we try to
> interrupt its fetcher thread. I noticed that SimpleConsumer.scala catches
> Throwable in its sendRequest method [2]. I'm wondering: if
> blockingChannel.send/receive throws a ClosedByInterruptException
> when the thread is interrupted, what happens? It looks like sendRequest will
> catch the exception (which I
> think clears the thread's interrupted flag), and then retries the send. If
> the send succeeds on the retry, I think that the ClosedByInterruptException
> exception is effectively swallowed, and the BrokerProxy will continue
> fetching messages as though its thread was never interrupted.
> Am I misunderstanding how things work?
> Cheers,
> Chris
> [1]
> https://github.com/apache/incubator-samza/blob/master/samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala#L126
> [2]
> https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/consumer/SimpleConsumer.scala#L75
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
