----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33532/ -----------------------------------------------------------
(Updated April 24, 2015, 8:23 p.m.) Review request for kafka. Bugs: KAFKA-2149 https://issues.apache.org/jira/browse/KAFKA-2149 Repository: kafka Description ------- Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 Diffs ----- core/src/main/scala/kafka/server/KafkaConfig.scala cfbbd2be550947dd2b3c8c2cab981fa08fb6d859 core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 2428dbd7197a58cf4cad42ef82b385dab3a2b15e Diff: https://reviews.apache.org/r/33532/diff/ Testing (updated) ------- Before this patch: brought up a controller with KAFKA-1809 and then an older broker. Broker gets BufferUnderflowException from UpdateMetadataRequest. After this patch: brought up a controller with this patch and then an older broker. Broker no longer gets BufferUnderflowException. Thanks, Onur Karaman