-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33417/#review81238
-----------------------------------------------------------

Ship it!



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131504>

    typo



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131513>

    Node1 should be the only ready node



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131506>

    batche -> batch



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131508>

    paritition -> partition



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131509>

    tp1 should backoff while tp2 should not



clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
<https://reviews.apache.org/r/33417/#comment131514>

    Node1 should be the only ready node


- Joel Koshy


On April 21, 2015, 10:51 p.m., Jiangjie Qin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33417/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 10:51 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2138
>     https://issues.apache.org/jira/browse/KAFKA-2138
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-2138 honor retry backoff in KafkaProducer
> 
> 
> Diffs
> -----
> 
>   
> clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
>  0e7ab29a07301309aa8ca5b75b32b8e05ddc3a94 
>   
> clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
>  05e2929c0a9fc8cf2a8ebe0776ca62d5f3962d5c 
> 
> Diff: https://reviews.apache.org/r/33417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiangjie Qin
> 
>

Reply via email to