[ https://issues.apache.org/jira/browse/KAFKA-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506087#comment-14506087 ]
Jay Kreps commented on KAFKA-2141: ---------------------------------- Do you mean adding it to cover java code that isn't in the clients/ directory? I tried to set that up but somehow the mixture of scala and java caused confusion... > Integrate checkstyle for Java code > ---------------------------------- > > Key: KAFKA-2141 > URL: https://issues.apache.org/jira/browse/KAFKA-2141 > Project: Kafka > Issue Type: Bug > Reporter: Guozhang Wang > Assignee: Guozhang Wang > > As we move from Scala to more Java code, it is better to start firmly with > coding style. So I propose integrating checkstyle to catch coding style > issues at build / test time to save on reviewing efforts. It has been > integrated to Kafka (KAFKA-1915), and my personal experience is that once the > import / code configs are set appropriately it is worthwhile. -- This message was sent by Atlassian JIRA (v6.3.4#6332)