----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/#review80633 -----------------------------------------------------------
Thanks for the patch. Just a minor comment below. core/src/main/scala/kafka/controller/ControllerChannelManager.scala <https://reviews.apache.org/r/33342/#comment130763> We can just use the constuctor that doesn't take any parameter. - Jun Rao On April 19, 2015, 6:10 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33342/ > ----------------------------------------------------------- > > (Updated April 19, 2015, 6:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2122 > https://issues.apache.org/jira/browse/KAFKA-2122 > > > Repository: kafka > > > Description > ------- > > KAFKA-2122. Remove controller.message.queue.size Config. > > > Diffs > ----- > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > 97acdb23f6e95554c3e0357aa112eddfc875efbc > core/src/main/scala/kafka/server/KafkaConfig.scala > 69b772c1941865fbe15b34bb2784c511f8ce519a > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > 62d183248e3be4c83d2c768e762f61f92448c6a6 > > Diff: https://reviews.apache.org/r/33342/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
