[ 
https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501989#comment-14501989
 ] 

Jun Rao commented on KAFKA-1929:
--------------------------------

[~jholoman], thanks for the patch. A couple of comments.

1. Yes, it would be good to add the missing exceptions for 
OFFSET_LOAD_IN_PROGRESS, CONSUMER_COORDINATOR_NOT_AVAILABLE, and  
NOT_COORDINATOR_FOR_CONSUMER in client.

2. Could we get rid of ErrorMapping and just use Errors instead? This means 
bigger refactoring. However, it's probably better for the long term since it 
avoid duplicated code.

> Convert core kafka module to use the errors in org.apache.kafka.common.errors
> -----------------------------------------------------------------------------
>
>                 Key: KAFKA-1929
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1929
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jay Kreps
>            Assignee: Jeff Holoman
>         Attachments: KAFKA-1929.patch
>
>
> With the introduction of the common package there are now a lot of errors 
> duplicated in both the common package and in the server. We should refactor 
> the server code (but not the scala clients) to switch over to the exceptions 
> in common.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to