> On April 16, 2015, 5:29 p.m., Ewen Cheslack-Postava wrote: > > Looks good, left a few comments. > > > > KafkaConsumer suffers from this same problem. Patching that should be > > pretty much identical -- any chance you could extend this to cover that as > > well?
sure. I can extend this to KafkaConsumer later. - Steven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/#review80346 ----------------------------------------------------------- On April 16, 2015, 5:44 p.m., Steven Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33242/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 5:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2121 > https://issues.apache.org/jira/browse/KAFKA-2121 > > > Repository: kafka > > > Description > ------- > > add a unit test file > > > changes based on Ewen's review feedbacks > > > fix capitalization in error log > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > b91e2c52ed0acb1faa85915097d97bafa28c413a > > clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33242/diff/ > > > Testing > ------- > > > Thanks, > > Steven Wu > >
