-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
-----------------------------------------------------------
(Updated April 13, 2015, 6:55 p.m.)
Review request for kafka.
Bugs: KAFKA-1334
https://issues.apache.org/jira/browse/KAFKA-1334
Repository: kafka
Description
-------
add heartbeat to coordinator
todo:
- handle existing consumers changing their subscribed topics
- see how it performs under real load
- see if IO can be moved out of the locks
- figure out how to make ConsumerCoordinator easy to test
- figure out how to close connections on consumer failure
- decide if consumer ids should be predictable or random
- figure out a good timeout value for JoinGroupRequest
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
e55ab11df4db0b0084f841a74cbcf819caf780d5
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
36aa412404ff1458c7bef0feecaaa8bc45bed9c7
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala
456b602245e111880e1b8b361319cabff38ee0e9
core/src/main/scala/kafka/coordinator/ConsumerRegistry.scala
2f5797064d4131ecfc9d2750d9345a9fa3972a9a
core/src/main/scala/kafka/coordinator/DelayedHeartbeat.scala
6a6bc7bc4ceb648b67332e789c2c33de88e4cd86
core/src/main/scala/kafka/coordinator/DelayedJoinGroup.scala
df60cbc35d09937b4e9c737c67229889c69d8698
core/src/main/scala/kafka/coordinator/DelayedRebalance.scala
8defa2e41c92f1ebe255177679d275c70dae5b3e
core/src/main/scala/kafka/coordinator/Group.scala PRE-CREATION
core/src/main/scala/kafka/coordinator/GroupRegistry.scala
94ef5829b3a616c90018af1db7627bfe42e259e5
core/src/main/scala/kafka/coordinator/HeartbeatBucket.scala
821e26e97eaa97b5f4520474fff0fedbf406c82a
core/src/main/scala/kafka/coordinator/PartitionAssignor.scala PRE-CREATION
core/src/main/scala/kafka/server/DelayedOperationKey.scala
b673e43b0ba401b2e22f27aef550e3ab0ef4323c
core/src/main/scala/kafka/server/KafkaApis.scala
b4004aa3a1456d337199aa1245fb0ae61f6add46
core/src/main/scala/kafka/server/KafkaServer.scala
c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/server/OffsetManager.scala
420e2c3535e722c503f13d093849469983f6f08d
Diff: https://reviews.apache.org/r/33088/diff/
Testing
-------
Thanks,
Onur Karaman
