----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33125/#review79901 -----------------------------------------------------------
Ship it! LGTM. Just a minor comment. clients/src/test/java/org/apache/kafka/clients/MetadataTest.java <https://reviews.apache.org/r/33125/#comment129487> Maybe add a comment explaining we do this to make sure update happen after metadata update is requestd? - Jiangjie Qin On April 13, 2015, 7:36 a.m., Rajini Sivaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33125/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 7:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2089 > https://issues.apache.org/jira/browse/KAFKA-2089 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-2089: Fix timing issue in MetadataTest > > > Diffs > ----- > > clients/src/test/java/org/apache/kafka/clients/MetadataTest.java > 928087d29deb80655ca83726c1ebc45d76468c1f > > Diff: https://reviews.apache.org/r/33125/diff/ > > > Testing > ------- > > > Thanks, > > Rajini Sivaram > >
