[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491172#comment-14491172 ]
Jay Kreps commented on KAFKA-1646: ---------------------------------- This is pretty critical code and there have been a few issues with these patches so far which is what is making me a little skiddish. [~waldenchen] can you walk me through what you guys are doing in the way of validation and performance testing? Also, I agree with your suggestion of making this a configuration rather than an OS specific check. Theoretically this could help with Linux filesystems and conversely Windows may later get smarter about preallocation. How about log.preallocate={true/false} defaulting to false. > Improve consumer read performance for Windows > --------------------------------------------- > > Key: KAFKA-1646 > URL: https://issues.apache.org/jira/browse/KAFKA-1646 > Project: Kafka > Issue Type: Improvement > Components: log > Affects Versions: 0.8.1.1 > Environment: Windows > Reporter: xueqiang wang > Assignee: xueqiang wang > Labels: newbie, patch > Attachments: Improve consumer read performance for Windows.patch, > KAFKA-1646-truncate-off-trailing-zeros-on-broker-restart-if-bro.patch, > KAFKA-1646_20141216_163008.patch, KAFKA-1646_20150306_005526.patch, > KAFKA-1646_20150312_200352.patch > > > This patch is for Window platform only. In Windows platform, if there are > more than one replicas writing to disk, the segment log files will not be > consistent in disk and then consumer reading performance will be dropped down > greatly. This fix allocates more disk spaces when rolling a new segment, and > then it will improve the consumer reading performance in NTFS file system. > This patch doesn't affect file allocation of other filesystems, for it only > adds statements like 'if(Os.iswindow)' or adds methods used on Windows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)