Run Rao,
Thanks for reviewing it again. What commands do you run to show unused
imports? When I run "grandle --daemon test", it did not show these (there
were some warnings, but not unused imports). I thought that would have
shown these things.
Tong Li
OpenStack & Kafka Community Development
Building 501/B205
liton...@us.ibm.com
From: "Jun Rao (JIRA)" <j...@apache.org>
To: dev@kafka.apache.org
Date: 04/06/2015 12:48 AM
Subject: [jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with
o.a.k.common.utils.Utils
[
https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1926:
---------------------------
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for rebasing the latest patch. +1. Committed to trunk after removing
unused imports in a few files.
> Replace kafka.utils.Utils with o.a.k.common.utils.Utils
> -------------------------------------------------------
>
> Key: KAFKA-1926
> URL: https://issues.apache.org/jira/browse/KAFKA-1926
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.2.0
> Reporter: Jay Kreps
> Assignee: Tong Li
> Labels: newbie, patch
> Fix For: 0.8.3
>
> Attachments: KAFKA-1926.patch, KAFKA-1926.patch,
KAFKA-1926.patch, KAFKA-1926.patch, KAFKA-1926_2015-04-01_22:16:46.patch,
KAFKA-1926_2015-04-05_23:45:13.patch
>
>
> There is currently a lot of duplication between the Utils class in common
and the one in core.
> Our plan has been to deprecate duplicate code in the server and replace
it with the new common code.
> As such we should evaluate each method in the scala Utils and do one of
the following:
> 1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general
purpose utility in active use that is not Kafka-specific. If we migrate it
we should really think about the API and make sure there is some test
coverage. A few things in there are kind of funky and we shouldn't just
blindly copy them over.
> 2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will
hold any utilities that really need to make use of Scala features to be
convenient.
> 3. Delete it if it is not used, or has a bad api.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
