Thanks everyone for the patient discussion. I really learned a lot from it!
KIP-15 is closed with 3 binding +1 and 1 non-binding +1. (Will improve the KIP description as Gwen suggested.) On 3/27/15, 2:05 PM, "Gwen Shapira" <gshap...@cloudera.com> wrote: >+1 (non-binding) > >I really like the new API. > >One thing to clarify in the docs: >"If sender thread calls close(), it will block forever. So if a >close() call is called from sender thread, an error message will be >put in the log and close(0) will be called instead." > >I think we should explicitly mention that we are talking about >callback messages calling close(), and that we are preventing a >deadlock here. >The only reason I could see that "sender thread calls close()" refers >to the callbacks was because I followed the discussion on the list. > >Gwen > >On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin ><j...@linkedin.com.invalid> wrote: >> >>https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+me >>thod+with+a+timeout+in+the+producer >> >> Let us vote again!
