> On March 25, 2015, 8:37 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 325 > > <https://reviews.apache.org/r/32465/diff/1/?file=904867#file904867line325> > > > > Wondering if we call System.exit(-1) directly from one of the MM > > thread, if we have some shutdown hook in the container will that cause > > deadlock?
Good point. Actually we can just put everything into the big try/catch/finally block. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/#review77789 ----------------------------------------------------------- On March 25, 2015, 8:48 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32465/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 8:48 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2047 > https://issues.apache.org/jira/browse/KAFKA-2047 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comment. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 4f3c4c872e144195bb4b742b802fa3b931edb534 > > Diff: https://reviews.apache.org/r/32465/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
