[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363429#comment-14363429 ]
Gwen Shapira commented on KAFKA-1809: ------------------------------------- [~junrao]: 1. Addressed all sub-points 2. I think using actual version numbers in the config is more admin-friendly. I changed the parseConfig function to just use the 3 significant version numbers. 3. Fixed 4. good catch, that was silly :) fixed. 5. Fixed 6. I had to change this configurationin order to test end-to-end with a non-default protocol 7. Fixed 8. Yep. 9. Merge bug. Fixed this. 10. TRACE is used for testing only, because it was important to make sure that things still work when I use the non-default protocol. For example in SocketServerTest, but also I used it in manual testing. 11. Fixed 12. For performance reasons. Especially when validating the segments at the end. In current patch I changed it for all replica_testcases. 13. Ick! update metadatarequest was missing from the ser/de test suite! added it and validated that it catches the issue. 14. Ran system-tests (replica testcases only) 14.2 Ran with console producer and consumer. I'll open a separate JIRA for the rest of the tools, but I think it can go after we add the security protocol implementations. 14.3 Opened separate JIRA for this. > Refactor brokers to allow listening on multiple ports and IPs > -------------------------------------------------------------- > > Key: KAFKA-1809 > URL: https://issues.apache.org/jira/browse/KAFKA-1809 > Project: Kafka > Issue Type: Sub-task > Components: security > Reporter: Gwen Shapira > Assignee: Gwen Shapira > Attachments: KAFKA-1809.patch, KAFKA-1809.v1.patch, > KAFKA-1809.v2.patch, KAFKA-1809.v3.patch, > KAFKA-1809_2014-12-25_11:04:17.patch, KAFKA-1809_2014-12-27_12:03:35.patch, > KAFKA-1809_2014-12-27_12:22:56.patch, KAFKA-1809_2014-12-29_12:11:36.patch, > KAFKA-1809_2014-12-30_11:25:29.patch, KAFKA-1809_2014-12-30_18:48:46.patch, > KAFKA-1809_2015-01-05_14:23:57.patch, KAFKA-1809_2015-01-05_20:25:15.patch, > KAFKA-1809_2015-01-05_21:40:14.patch, KAFKA-1809_2015-01-06_11:46:22.patch, > KAFKA-1809_2015-01-13_18:16:21.patch, KAFKA-1809_2015-01-28_10:26:22.patch, > KAFKA-1809_2015-02-02_11:55:16.patch, KAFKA-1809_2015-02-03_10:45:31.patch, > KAFKA-1809_2015-02-03_10:46:42.patch, KAFKA-1809_2015-02-03_10:52:36.patch, > KAFKA-1809_2015-03-16_09:02:18.patch > > > The goal is to eventually support different security mechanisms on different > ports. > Currently brokers are defined as host+port pair, and this definition exists > throughout the code-base, therefore some refactoring is needed to support > multiple ports for a single broker. > The detailed design is here: > https://cwiki.apache.org/confluence/display/KAFKA/Multiple+Listeners+for+Kafka+Brokers -- This message was sent by Atlassian JIRA (v6.3.4#6332)