[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357725#comment-14357725 ]
Jun Rao commented on KAFKA-1910: -------------------------------- Are the changes in ConsumerTest needed? The extra logging and sleep seem to be just for debugging. Other than that. +1. Ran the tests locally 20 times and they all pass. > Refactor KafkaConsumer > ---------------------- > > Key: KAFKA-1910 > URL: https://issues.apache.org/jira/browse/KAFKA-1910 > Project: Kafka > Issue Type: Sub-task > Components: consumer > Reporter: Guozhang Wang > Assignee: Guozhang Wang > Attachments: KAFKA-1910.patch, KAFKA-1910_2015-03-05_14:55:33.patch > > > KafkaConsumer now contains all the logic on the consumer side, making it a > very huge class file, better re-factoring it to have multiple layers on top > of KafkaClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)