----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31927/#review76130 -----------------------------------------------------------
Yes, we need to set the backoff for the consumerFetcherThread as well. We can just use refreshLeaderBackoffMs. core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31927/#comment123577> Instead of adding the new backOffWaitLatch, we can probably just wait on the existing partitionMapCond. This way, if there is a change in partitions, the thread can wake up immediately. We probably can improve shutdown() a bit to wake up the thread waiting on the partitionMapCond. To do that, we can do the following steps in shutdown(). initiateShutdown() partitionMapCond.signalAll() awaitShutdown() simpleConsumer.close() - Jun Rao On March 11, 2015, 5:41 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31927/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 5:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 8c281d4668f92eff95a4a5df3c03c4b5b20e7095 > core/src/main/scala/kafka/server/KafkaConfig.scala > 48e33626695ad8a28b0018362ac225f11df94973 > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > d6d14fbd167fb8b085729cda5158898b1a3ee314 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > c124c8df5b5079e5ffbd0c4ea359562a66aaf317 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 52c79201af7c60f9b44a0aaa09cdf968d89a7b87 > > Diff: https://reviews.apache.org/r/31927/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
