----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/#review75120 -----------------------------------------------------------
Thanks for the patch. A few minor comments below. core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/31591/#comment122063> The last %s should be %d. core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/31591/#comment122065> Our current coding convention is not to wrap single line statement in {}. core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/31591/#comment122068> Space should be added after comma. core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala <https://reviews.apache.org/r/31591/#comment122070> This change is already committed. - Jun Rao On March 4, 2015, 1:17 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31591/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 1:17 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1992 > https://issues.apache.org/jira/browse/KAFKA-1992 > > > Repository: kafka > > > Description > ------- > > add logging per Jiangjie Qin comment > > > revert unintentional changes to log4j > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > c4bf48a801007ebe7497077d2018d6dffe1677d4 > core/src/main/scala/kafka/server/DelayedProduce.scala > 4d763bf05efb24a394662721292fc54d32467969 > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > ba48a636dd0b0ed06646d56bb36aa3d43228604f > > Diff: https://reviews.apache.org/r/31591/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
