[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342042#comment-14342042 ]
Gwen Shapira commented on KAFKA-1992: ------------------------------------- Created reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > ------------------------------------------------------------------------------------- > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug > Reporter: Gwen Shapira > Attachments: KAFKA-1992.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)