> On Feb. 27, 2015, 8:47 p.m., Joel Koshy wrote: > > Minor locking issue noted below. I can take care of that. > > > > This obviously does not cover the case of committing offsets to a topic > > that is currently being deleted. I think that can be done in a separate > > jira. Can you file one?
Joel, Will open a new and send PR. Thanks. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review74569 ----------------------------------------------------------- On Feb. 27, 2015, 9:50 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29912/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 9:50 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1852 > https://issues.apache.org/jira/browse/KAFKA-1852 > > > Repository: kafka > > > Description > ------- > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. Added > contains method to MetadataCache. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 703886a1d48e6d2271da67f8b89514a6950278dd > core/src/main/scala/kafka/server/KafkaServer.scala > 426e522fc9819a0fc0f4e8269033552d716eb066 > core/src/main/scala/kafka/server/MetadataCache.scala > 4c70aa7e0157b85de5e24736ebf487239c4571d0 > core/src/main/scala/kafka/server/OffsetManager.scala > 83d52643028c5628057dc0aa29819becfda61fdb > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > a2bb8855c3c0586b6b45b53ce534edee31b3bd12 > > Diff: https://reviews.apache.org/r/29912/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
