[ 
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335345#comment-14335345
 ] 

Guozhang Wang commented on KAFKA-1864:
--------------------------------------

I did not realize the change of "Math.min(config.offsetsTopicReplicationFactor, 
aliveBrokers.length)" until encountered some new consumer test failures due to 
this. 

In practice the __consumer_offsets topic should be created as part of the Kafka 
cluster starting up process, but today it will only be done so when the first 
consumer fetch comes and hence it is likely we are not guaranteeing the offset 
replication factor. 

I think in general we should always honor the offset replication factor, and 
when there are not enough # of live brokers we should not proceed with the 
topic creation and return error code to the clients asking metadata, I am OK 
with negative values indicating soft requirements though. What do you think 
[~junrao]?

> Revisit defaults for the internal offsets topic
> -----------------------------------------------
>
>                 Key: KAFKA-1864
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1864
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.0
>            Reporter: Neha Narkhede
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2.0
>
>         Attachments: kafka-1864.patch
>
>
> Realize this is late, but as I was reviewing the 0.8.2 RC, I found that our 
> defaults for the offsets topic are not ideal. The # of partitions currently 
> default to 1 and the replication factor is 1 as well. Granted that the 
> replication factor is changeable in the future (through the admin tool), 
> changing the # of partitions is a very disruptive change. The concern is that 
> this feature is on by default on the server and will be activated the moment 
> the first client turns on kafka based offset storage. 
> My proposal is to change the # of partitions to something large (50 or so) 
> and change the replication factor to min(# of alive brokers, configured 
> replication factor)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to