[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333389#comment-14333389 ]
Joel Koshy commented on KAFKA-1755: ----------------------------------- Also, I have an incremental patch that prevents the log cleaner from quitting due to uncaught errors while cleaning a specific partition. It basically moves that partition to a permanent failed state and allows the cleaner to continue compacting other partitions. It continues to include the failed partition when computing the max dirty ratio so you can still accurately alert on that metric. We can discuss whether we want to add that or not. > Improve error handling in log cleaner > ------------------------------------- > > Key: KAFKA-1755 > URL: https://issues.apache.org/jira/browse/KAFKA-1755 > Project: Kafka > Issue Type: Bug > Reporter: Joel Koshy > Assignee: Joel Koshy > Labels: newbie++ > Fix For: 0.8.3 > > Attachments: KAFKA-1755.patch > > > The log cleaner is a critical process when using compacted topics. > However, if there is any error in any topic (notably if a key is missing) > then the cleaner exits and all other compacted topics will also be adversely > affected - i.e., compaction stops across the board. > This can be improved by just aborting compaction for a topic on any error and > keep the thread from exiting. > Another improvement would be to reject messages without keys that are sent to > compacted topics although this is not enough by itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)