[
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332024#comment-14332024
]
Neha Narkhede commented on KAFKA-1566:
--------------------------------------
[~sriharsha] Happy to help check it in. But it doesn't apply -
{code}
nnarkhed-mn1:kafka nnarkhed$ git am --signoff < 1566.patch
Applying: KAFKA-1566. Kafka environment configuration (kafka-env.sh).
error: patch failed: bin/windows/kafka-run-class.bat:27
error: bin/windows/kafka-run-class.bat: patch does not apply
Patch failed at 0001 KAFKA-1566. Kafka environment configuration (kafka-env.sh).
The copy of the patch that failed is found in:
/Users/nnarkhed/Projects/kafka/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
{code}
> Kafka environment configuration (kafka-env.sh)
> ----------------------------------------------
>
> Key: KAFKA-1566
> URL: https://issues.apache.org/jira/browse/KAFKA-1566
> Project: Kafka
> Issue Type: Improvement
> Components: tools
> Reporter: Cosmin Lehene
> Assignee: Sriharsha Chintalapani
> Labels: newbie
> Fix For: 0.8.3
>
> Attachments: KAFKA-1566.patch
>
>
> It would be useful (especially for automated deployments) to have an
> environment configuration file that could be sourced from the launcher files
> (e.g. kafka-run-server.sh).
> This is how this could look like kafka-env.sh
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
> -XX:InitiatingHeapOccupancyPercent=35' %>"
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>"
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
> {code}
> kafka-server-start.sh
> {code}
> ...
> source $base_dir/config/kafka-env.sh
> ...
> {code}
> This approach is consistent with Hadoop and HBase. However the idea here is
> to be able to set these values in a single place without having to edit
> startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
