----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31256/#review73413 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/31256/#comment119750> Overall, this change makes sense to me. However, now the startup and shutdown sequence is complicated and tricky to understand. It will be very helpful to document your findings in a comment on both startup and shutdown on why the sequence has to be this way. Also let's leave a note on being very careful before changing the sequence. - Neha Narkhede On Feb. 21, 2015, 9:12 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31256/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 9:12 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1887 > https://issues.apache.org/jira/browse/KAFKA-1887 > > > Repository: kafka > > > Description > ------- > > KAFKA-1887. controller error message on shutting the last broker. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaServer.scala > 7e5ddcb9be8fcef3df6ebc82a13ef44ef95f73ae > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > ba48a636dd0b0ed06646d56bb36aa3d43228604f > > Diff: https://reviews.apache.org/r/31256/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
