----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31226/ -----------------------------------------------------------
Review request for kafka. Repository: kafka Description ------- adding try/catch to getting hostname to allow the use of the first non-loopback IP address when hostname is not resolvable. Diffs ----- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 3e1718b core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 8c4687b Diff: https://reviews.apache.org/r/31226/diff/ Testing ------- for testing this code I included the unit test that forces the generation of the ID however if you cannot get your local to not resovle you will need to manually throw the exception in the try/catch in order to test. Thanks, Jonathan Rafalski